Skip to content

CompatHelper: bump compat for Setfield to 1 for package test, (keep existing compat) #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the Setfield package from 0.7.1, 0.8 to 0.7.1, 0.8, 1 for package test.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@devmotion devmotion force-pushed the compathelper/new_version/2022-05-25-00-09-27-777-00059585216 branch from 93cb0e4 to e78aaba Compare May 25, 2022 00:09
@yebai
Copy link
Member

yebai commented May 30, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented May 30, 2022

👎 Rejected by too few approved reviews

@devmotion
Copy link
Member

This PR is included in #406 as well. That PR is not merged yet since some package was holding back Setfield.

@yebai yebai merged commit 3092c6d into master Nov 2, 2022
@yebai yebai deleted the compathelper/new_version/2022-05-25-00-09-27-777-00059585216 branch November 2, 2022 20:40
alyst pushed a commit to alyst/DynamicPPL.jl that referenced this pull request Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants